CI: Pin Windows runners to windows-2022#1156
Open
wooksong wants to merge 1 commit into
Open
Conversation
…ilds)
GitHub's `windows-latest` image now ships Visual Studio 2026 (MSVC 19.5),
which breaks both Windows CI jobs:
- `cmake Windows`: `conan profile detect` selects msvc 195, so Conan asks
CMake for the "Visual Studio 18 2026" generator, which the installed
CMake cannot create. The vendored foonathan-lexy dependency fails to
build with "Could not create named generator Visual Studio 18 2026".
- `Pixi (conda)`: `cmake ..` defaults to the "Visual Studio 17 2022"
generator, which is no longer present ("could not find any instance of
Visual Studio").
Pin both jobs to windows-2022 (VS 2022 / MSVC 19.3x) to restore green CI.
Also set fail-fast: false on the pixi matrix so the ubuntu leg is no
longer masked by a Windows failure.
wooksong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
windows-latestGitHub-hosted runners have been upgraded to Visual Studio 2026 (MSVC 19.5). This breaks both Windows CI jobs on every current PR:cmake Windows(Debug & Release) —conan profile detectselectsmsvc 195, so Conan asks CMake for theVisual Studio 18 2026generator, which the installed CMake cannot create. The vendoredfoonathan-lexydependency fails to build:Pixi (conda)(windows) —cmake ..defaults to theVisual Studio 17 2022generator, which is no longer present:Pixi (conda)(ubuntu) was not actually broken — it was cancelled by fail-fast when the Windows leg died.This is an environment regression, not a code change: the same failures currently hit #1152, #1154, and #1155, while older PRs (#1145, #1146) passed.
masterlast ran these jobs green on 2026-05-19, before the runner upgrade.Fix
windows-2022(VS 2022 / MSVC 19.3x), a CMake + generator combo that both Conan and pixi already work with.fail-fast: falseon the pixi matrix so a Windows failure no longer masks the ubuntu leg's real status.This unblocks the currently-red PRs (#1152, #1154, #1155). A forward-looking follow-up could instead make the build VS 2026-compatible (newer CMake / force the Ninja generator), but pinning restores green CI reliably today.
Note
The
ros2-rollingfailure seen on recent PRs is a separate, transient ROS Rolling apt-repo outage (Unable to locate package ros-rolling-ros-environment) and is not addressed here — it clears on re-run.